DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

human-format: add typing information for human-format

Open liushuyu opened this issue 3 years ago • 2 comments

Select one of these and delete the others:

If adding a new definition:

  • [X] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [X] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [X] Create it with dts-gen --dt, not by basing it on an existing project.
  • [X] Represents shape of module/library correctly
  • [X] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [X] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

liushuyu avatar Aug 11 '22 05:08 liushuyu

@liushuyu Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

  • human-format (new!) — on npm, on unpkg
    • 1 added owner: @DefinitelyTyped

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61654,
  "author": "liushuyu",
  "headCommitOid": "a92647b168fd8c74d67fae97dbff253b7749d404",
  "mergeBaseOid": "fc9b16957473f81a1d708e6948b8d61e292aeb58",
  "lastPushDate": "2022-08-14T23:33:59.000Z",
  "lastActivityDate": "2022-08-16T01:55:27.000Z",
  "mergeOfferDate": "2022-08-15T10:19:26.000Z",
  "mergeRequestDate": "2022-08-16T01:55:27.000Z",
  "mergeRequestUser": "liushuyu",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "human-format",
      "kind": "add",
      "files": [
        {
          "path": "types/human-format/human-format-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/human-format/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/human-format/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/human-format/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "DefinitelyTyped"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-08-15T10:18:41.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1211558118,
  "ciResult": "pass"
}

typescript-bot avatar Aug 11 '22 05:08 typescript-bot

🔔 @liushuyu — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

typescript-bot avatar Aug 11 '22 05:08 typescript-bot

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot avatar Aug 14 '22 23:08 typescript-bot

@liushuyu: Everything looks good here. I am ready to merge this PR (at a92647b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

typescript-bot avatar Aug 15 '22 10:08 typescript-bot

Ready to merge

liushuyu avatar Aug 16 '22 01:08 liushuyu