Hangjie Mo

Results 89 comments of Hangjie Mo

Hi @L-maple, #49998 already be fixed by https://github.com/pingcap/tidb/pull/52442. If you are still interested with this PR, you can modify it and keep the modifications for #49995. If there is no...

> type Cpu has no field or method Ge https://github.com/pingcap/tidb/issues/49742#issuecomment-1986823009 maybe you could follow this comment.

> @Defined2014 @mjonss Long time no chat, this PR can be reviewed again~ Please fix failed test cases.

> @Defined2014 I test the `check_dev` on local, but it success. How should I pass the `check_dev`? ![image](https://private-user-images.githubusercontent.com/20724552/325965900-9d19429f-21b6-496f-9452-58fe3ae3c472.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQzODAxNTEsIm5iZiI6MTcxNDM3OTg1MSwicGF0aCI6Ii8yMDcyNDU1Mi8zMjU5NjU5MDAtOWQxOTQyOWYtMjFiNi00OTZmLTk0NTItNThmZTNhZTNjNDcyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI5VDA4MzczMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIwN2JmMzA3OTgwNzMyZjI3MmJmYmQ1YjU0ZmYyZmYwMjA4YzQ2Zjg1Y2I1ZGIyNjU5OTFlNTFkN2UxNGUxZjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ag09s8pR_iR0K-joWBll_c0tjUZMWt4uOtllA4KPlXk) Maybe you could merge master and run test again. > @Defined2014 Hi,...

> Hi @L-maple, #49998 already be fixed by #52442. If you are still interested with this PR, you can modify it and keep the modifications for #49995. > > If...

Is this added to every TCP connection? Will it be too heavy to add atomic variables here which have a big impact on performance?

> It sounds okay but I'm not sure whether it is a better idea to count at upper layers for more flexibility. If one client could support multiple tenants, counting...