Hours icon indicating copy to clipboard operation
Hours copied to clipboard

Error message sign up happyhours.io not clear

Open Marthyn opened this issue 11 years ago • 5 comments

screen shot 2014-03-19 at 11 06 50

I'm guessing i need to go to defacto.happyhours.io to register. But the error message should say that. It could be anything now that has been taken.

Marthyn avatar Mar 19 '14 10:03 Marthyn

It's mainly context. From the main site (happyhours.io), people can sign up for an Hours account in the sense of having their own subdomain, etc. Everybody else can then sign up for that specific instance (sortof) of Hours at that subdomain only (plus there are still some constraints with regard to email, like Yammer does.

Still, obviously this message should be better.

dkhgh avatar Mar 19 '14 10:03 dkhgh

Yeah I think this is not using the errors.full_messages, will look into it :)

Ideally it would show it inline in the form btw

jurre avatar Mar 19 '14 10:03 jurre

  def create
    @account = Account.new(account_params)
    if @account.valid?
      Apartment::Database.create(@account.subdomain)
      Apartment::Database.switch(@account.subdomain)
      @account.save
      redirect_to new_user_session_url(subdomain: @account.subdomain)
    else
      render action: "new", flash: { error: @account.errors.full_messages.join(", ") }
    end
  end

should fix it, I think. Need to write specs first though. It also redirects to /accounts which is weird

jurre avatar Mar 19 '14 18:03 jurre

Looks like this now btw:

screen shot 2014-08-13 at 17 20 29

dkhgh avatar Aug 13 '14 15:08 dkhgh

Huh, didn't you change the look of that whole page?

jurre avatar Aug 13 '14 15:08 jurre