dedalus icon indicating copy to clipboard operation
dedalus copied to clipboard

Updates to HDF5 metadata

Open jsoishi opened this issue 3 years ago • 7 comments

  • Fixes issue #190
  • addes scale names to scale objects as well as tasks
  • addes coordinate scales coords for tensor component dimensions populated from coordinate name strings from the CoordinateSystem object

jsoishi avatar Apr 26 '22 14:04 jsoishi

Looks good. Only issue I can think of is that this could be misleading if we save vectors or tensors in coeff space, since there the coefficients may correspond to spin/regularity components, not the coordinate components like in grid space.

kburns avatar Apr 26 '22 14:04 kburns

That's a good point. We could do something like s_1/2, s_-1/2, r_0, r_1, etc in that case, basis dependent?

jsoishi avatar Apr 26 '22 15:04 jsoishi

Yeah or maybe just {-1, 0, +1} or even {-, 0, +}, and you have to know its spin or regularity based on the context? Any thoughts @lecoanet?

kburns avatar Apr 26 '22 19:04 kburns

Our ordering is {-, +, 0}. Using {-, +, 0} for both spin and regularity bases would be fine. But {s-, s+, s0} and {r-, r+, r0} might be a bit more descriptive. Don't think we ever have spin 1/2.

lecoanet avatar Apr 27 '22 03:04 lecoanet

Too much QM teaching...

On Tue, Apr 26, 2022, 23:26 lecoanet @.***> wrote:

Our ordering is {-, +, 0}. Using {-, +, 0} for both spin and regularity bases would be fine. But {s-, s+, s0} and {r-, r+, r0} might be a bit more descriptive. Don't think we ever have spin 1/2.

— Reply to this email directly, view it on GitHub https://github.com/DedalusProject/dedalus/pull/192#issuecomment-1110493352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7SHYNBTV3XPBPQXNH52RDVHCXXVANCNFSM5UMDX5TQ . You are receiving this because you authored the thread.Message ID: @.***>

jsoishi avatar Apr 27 '22 11:04 jsoishi

@jsoishi want to push this to a separate branch on the main repo?

kburns avatar Apr 28 '22 19:04 kburns

Marking as a draft since we're still WIP.

kburns avatar Apr 28 '22 19:04 kburns