ain icon indicating copy to clipboard operation
ain copied to clipboard
verified publisher icon DeFiCh

Remove irrelevant height branching after FCC

Open prasannavl opened this issue 3 years ago • 2 comments

/kind chore

  • Remove the unnecessary condition since FCC has kicked in.

prasannavl avatar Jun 03 '22 06:06 prasannavl

This shouldn't be removed from consensus as it is possible to modify prefork state (for example from bad snapshot or etc.).

The only fork checks that are safe to remove after hardfork kicks in is from RPC and part that are not in consensus!

Mixa84 avatar Jun 10 '22 11:06 Mixa84

How so? The mainnet does not have these TXs. Corrupt snapshot are exactly that - corrupt (different network/fork). It's irrelevant. It's just dead code and extra branches, that's unnecessary to maintain.

It is being intentionally removed. A bug prevented valid TXs from going in there. Now the bug is fixed. While it seems like a retroactive fix, it is not, since the mainnet TXs are already done. If someone launches a new network, it's bug-free (while the current network is still compatible)

TL;DR - There's no value in keeping these code branches.

prasannavl avatar Jun 22 '22 20:06 prasannavl