David Knapp

Results 50 comments of David Knapp

Can you elaborate? I just had a look at it and I don't have a idea what this is about in detail. Thanks!

> @Davknapp Did you verify, that this is now fixed with the pyramid volume bugfix? I only checked it for two different examples, where it worked. For a safe integration...

I was unable to reproduce this error. However I got some other error-messages related to pyramids, that I was able to fix. At some parts in the advection example it...

> I was unable to reproduce this error. However I got some other error-messages related to pyramids, that I was able to fix. At some parts in the advection example...

Thanks for the suggestion! I will try to do so during the next t8code-Coding-week!

Hey @jsaldia thank you for your suggestions! Feel free to open a PR with these changes. You can find our Contribution Guidelines here: https://github.com/DLR-AMR/t8code/wiki/Coding-Guideline#pull-requests

We could do two tests. One in the manner I just pushed. And another one where we test only for a small number of elements at very high-level. For the...

When implementing tests in a recursive matter, we can design them such that the starting element can be chosen freely. We then can initialise the recursive test via t8_element_set_linear_id for...

Is this still relevant for the CMake build system?

I think @sandro-elsweijer is already on it