Haring icon indicating copy to clipboard operation
Haring copied to clipboard

MarkdownHeader pattern also consumes hashtags

Open jcollas opened this issue 8 years ago • 1 comments

If you have text like "#hashtag\n# Header", both will be treated as a header. Since there's no space after the # in #hashtag, it shouldn't be processed into a header.

It would be nice if either the pattern was not fileprivate so consumers of the framework could change the behavior, or if the pattern in line 13 were changed to

fileprivate static let regex = "^(#{1,%@} \\s*(.+)$" # add space before \\s

Here's a reference to a similar issue and its resolution: https://github.com/chjj/marked/issues/201

jcollas avatar Jan 29 '18 17:01 jcollas

@jcollas Thanks for the information and the linked issue. Let me consider this for a few days and also, see if anyone else using the library has feedback on the best way to proceed. I saw a lot of good discussion on the linked issue and it's a lot to consider.

DavidLari avatar Jan 30 '18 12:01 DavidLari