TextRank icon indicating copy to clipboard operation
TextRank copied to clipboard

TokenizeText func doesn't return all sentences

Open koushki opened this issue 6 years ago • 2 comments

I expect text.parsedSentences should contain all sentences. let me explain the problem with code :)

place it in parse/tokenizer_test.go file

func TestTokenizeText(t *testing.T) {
	rule := NewRule()

	text := TokenizeText("Hi!!!", rule)
	assert.Equal(t, "Hi!", text.parsedSentences[0].original)
	assert.Equal(t, "!", text.parsedSentences[1].original)
	assert.Equal(t, "!", text.parsedSentences[2].original)
}

I expect this test should be passed, but apparently, it is not!

koushki avatar Mar 04 '19 14:03 koushki

Hi, I'm a beginner to open source. Could I have some pointers on where to start contributing to this project?

rahulk0127 avatar Apr 10 '19 01:04 rahulk0127

Hi,

Any contribution is welcome.

I recommend creating an issue here on GitHub then fork the repo and create a branch to that issue.

If you want to fix a logical error in the text ranking that's fine, but if you wish to add a new feature that should be discussed before.

I also recommend creating very small pull requests to make the whole process faster and more efficient.

Make sure GoReport is always on 100% https://goreportcard.com/report/github.com/DavidBelicza/TextRank and code coverage is near to 100% https://coveralls.io/github/DavidBelicza/TextRank?branch=master and please don't add 3rd party libraries to the project.

DavidBelicza avatar Apr 10 '19 06:04 DavidBelicza