Dave Tryon

Results 184 comments of Dave Tryon

This is fixed but we need to keep the bug in the resolved state until we actually release the updated package

@mcooley We'll discuss this in our weekly triage meeting then get back to you.

@mcooley We discussed this in our triage meeting and we don't feel that this is a good change for us at this time. The NativeMethods class may be old-school, but...

@WilcoFiers, as discussed offline, we're picking this up with the following proposed approach: 1. Replace the current link-in-text check with 4 pseudoClass checks--in each case, fall back to the non-pseudoClass...

@WilcoFiers, I've some experimentation with pseudoclasses, and have determined that there are 3 'tiers' where colors can be set, and we'll need to account for this in the revised rule....

I just figured out that G14 is already handled in [elementIsDistinct](https://github.com/dequelabs/axe-core/blob/develop/lib/commons/color/element-is-distinct.js#L27), so please ignore my comments on that. There's also a `focus` pseudoClass that fits into the High tier (I've...

We've hit a snag with this. We revised the code to use [window.getComputedStyle](https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle), but we've discovered that this API _intentionally_ disregards pseudoclasses. In fact, we even found a [chromium test](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-pseudo/highlight-pseudos-currentcolor-visited-computed-001.html;l=37)...

> @DaveTryon Is this ready again? @WilcoFiers: Yes, please take another pass. I left a comment of some behavior that I didn't expect in the integration tests

This is better in 1.1.2139.1, but I noticed a slight irregularity that we're working on fixing.

Irregularity has been fixed in current Canary builds. Closing