[Bug] Visual issues in the checklist
Current Behavior
During a review of changes, we run several queries on specific changed models to review data changes. Whenever anything is detected, we add such checks to the checklist which is synced to the cloud and can be later reviewed again. The preview is prepared in the CI step of the pipeline and whenever we start recce with recce server --cloud --review and switch to those checks we immediately see the results. However, we experience the following issues:
-
in the version 1.23.0: when scrolling through the results, the header is transparent (minor issue)
-
in the version 1.24.0:
-
the header is still transparent (as above)
-
the results for some checks are not shown unless you rerun the check
-
for the new entries (green) the values of the id column are not displayed
-
Expected Behavior
- the header should not be transparent (or at least not that much)
- the results should be displayed directly (as before 1.24.0)
- the values of the newly added entries in the ID column should be shown (as before 1.24.0)
Steps To Reproduce
We follow the same best practices by Recce as before and execute recce server --cloud --server as before.
The issue with checks not showing results and empty new entries is happening when using "custom queries" and selecting a primary key for a diff.
Relevant log output
Environment
- recce: 1.23.1, 1.24.0
- OS: Mac OSX (latest)
- Python: 3.11.13
- Data Warehouse: Databricks
- dbt: 1.10.11
Additional Context
No response
Hi @alexeyegorov, thanks for reporting the issue. For the transparent header issue, we plan to fix it in the next release. Let's focus on the second issue here.
Hello @alexeyegorov,
The following visual problems have been fixed in v1.24.2:
- the header should not be transparent
- the values of the newly added entries in the ID column should be shown
We are still working on the remaining one:
- the results should be displayed directly
Thanks for reporting these issues!
@wcchang1115 @kentwelcome you are fast, guys! 😬💯
Hi @alexeyegorov,
The remaining issue: the results should be displayed directly is fixed and included in Recce v1.25.0.
Thanks! 🙌
Thanks. I check it right now. I know I forgot to mention, but the transparent background for the ID column would also be a good idea. This happens whenever you can scroll horizontally.
Hi @alexeyegorov, Thank you for reporting this issue as well! We are currently working on a fix. We'll fix this in the next release.
Hello @alexeyegorov,
The horizontal scrolling visualization issue has been resolved in v1.26.0.
Please upgrade to this version at your convenience.
Thank you!