recce icon indicating copy to clipboard operation
recce copied to clipboard

[DRC-542] [Feature] Lineage graph was Maximum text size in diagram exceeded

Open tomoki-takahashi-oisix opened this issue 1 year ago • 3 comments

Describe the feature

I created a markdown for PR from the recce summary, but as shown below, there are too many related models, exceeding the display limit of the Lineage Graph.

スクリーンショット 2024-07-05 21 20 21

When launched with recce server, the lineage is displayed correctly as follows, but is it possible to add a feature to reduce the number of related lineages when creating a summary for PR using recce summary?

スクリーンショット 2024-07-05 21 24 03

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

DRC-542

tomoki-takahashi-oisix avatar Jul 05 '24 12:07 tomoki-takahashi-oisix

Hi @tomoki-takahashi-oisix

Thanks for filing this issue. This is a known issue, it's a hard limitation of GitHub PR comment.

Would you like to share with us the top-3 important things/nodes you want to see in this specific situation? For example, showing modified/added/removed nodes only. Or models with specific tags or groups?

even-wei avatar Jul 07 '24 15:07 even-wei

There is the 65,536 chars limit in the PR comment. If you are running this in the ci, you can consider to put the markdown result in the job summary

popcornylu avatar Jul 08 '24 00:07 popcornylu

@even-wei

Thank you for your reply. Personally, I would be happy if there was a feature that allows recce summary to be performed only on the results of "select models". If that's difficult, it might be good to have a filtering option like dbt's selector, such as -s 'hoge+1'.

tomoki-takahashi-oisix avatar Jul 08 '24 02:07 tomoki-takahashi-oisix