dinky icon indicating copy to clipboard operation
dinky copied to clipboard

[Bug] When a task submits a jar package, the jar package submission parameters cannot be modified at the task level

Open waywtdcc opened this issue 3 years ago • 5 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

When a task submits a jar package, the jar package submission parameters cannot be modified at the task level

image

What you expected to happen

When a task submits a jar package, the jar package submission parameters cannot be modified at the task level

How to reproduce

When a task submits a jar package, the jar package submission parameters cannot be modified at the task level

Anything else

No response

Version

0.6.5

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

waywtdcc avatar Jul 14 '22 02:07 waywtdcc

image

aiwenmo avatar Jul 14 '22 05:07 aiwenmo

Can this be modified at the task level? Because there may be only one package, the submission parameters will be different @aiwenmo

waywtdcc avatar Jul 15 '22 01:07 waywtdcc

It is not supported at present, and this feature can be easily extended.

aiwenmo avatar Jul 15 '22 05:07 aiwenmo

It is not supported at present, and this feature can be easily extended.

Ok, thank you, I hope the next version can be used

waywtdcc avatar Jul 15 '22 06:07 waywtdcc

Welcome to PR.

aiwenmo avatar Jul 16 '22 06:07 aiwenmo

@aiwenmo
I am willing to help fix this issue. In my approach, I will add a field called "paras" to the org.dinky.model.Task class to obtain startup parameters at the task level (this "paras" will be stored when the user saves the task). When this parameter is not empty, the JAR task will start using the task-level parameters instead of the parameters provided during JAR registration. And I think that main class can also be modified at the task level when user have different main classes in one JAR. There is some frontend work needed, but I haven't done any frontend work before. Is there anyone who can help with this? What do you think of this idea?

nzh9900 avatar Mar 20 '23 04:03 nzh9900

try 1.0

gaoyan1998 avatar Dec 25 '23 03:12 gaoyan1998