DataDog
Don't validate that endpoint is not empty because it doesn't need to be present
What does this PR do?
Remove the validation that endpoint is not empty when casting the crashtrackers parameters. The endpoint can be empty, because it will be read from env variables here https://github.com/DataDog/libdatadog/blob/paullgdc/crashtracker/fix_enpoint_env_read/crashtracker/src/telemetry.rs#L63
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
Codecov Report
Attention: Patch coverage is 95.59471% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 67.76%. Comparing base (
0d5e0d1) to head (2eb824e).
Additional details and impacted files
@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 67.55% 67.76% +0.20%
==========================================
Files 192 193 +1
Lines 24321 24476 +155
==========================================
+ Hits 16429 16585 +156
+ Misses 7892 7891 -1
| Components | Coverage Δ | |
|---|---|---|
| crashtracker | 19.34% <50.00%> (ø) |
|
| datadog-alloc | 98.76% <ø> (ø) |
|
| data-pipeline | 51.45% <ø> (ø) |
|
| data-pipeline-ffi | 0.00% <ø> (ø) |
|
| ddcommon | 85.24% <100.00%> (+0.01%) |
:arrow_up: |
| ddcommon-ffi | 74.93% <ø> (ø) |
|
| ddtelemetry | 56.09% <99.47%> (+2.36%) |
:arrow_up: |
| ipc | 81.27% <ø> (ø) |
|
| profiling | 78.09% <0.00%> (ø) |
|
| profiling-ffi | 60.05% <0.00%> (ø) |
|
| serverless | 0.00% <ø> (ø) |
|
| sidecar | 36.58% <ø> (ø) |
|
| sidecar-ffi | 0.00% <ø> (ø) |
|
| spawn-worker | 54.98% <ø> (ø) |
|
| trace-mini-agent | 69.12% <ø> (ø) |
|
| trace-normalization | 97.79% <ø> (ø) |
|
| trace-obfuscation | 95.74% <ø> (ø) |
|
| trace-protobuf | 30.76% <ø> (ø) |
|
| trace-utils | 78.29% <ø> (ø) |
For context, this is a request from @kevingosse . He want to use the crashtracker in situations were the it doesn't have access to the library variables, so the goal of this PR is to use agent host detection if no endpoint is provided by the crashtracker