integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard
verified publisher icon DataDog

Add Node to sc_id

Open michaelellwood opened this issue 8 months ago • 2 comments

What does this PR do?

Adds consul Node to sc_id

Motivation

Missing failed health checks. We have several services deployed across multiple nodes. The first node in the response was the only instance of the service being shown in the check summary. We were also seeing odd behavior when patching nodes due to this.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

michaelellwood avatar May 15 '25 19:05 michaelellwood

Hey @michaelellwood is this still being worked on? If so, do you need any guidance in the PR?

Kyle-Neale avatar May 28 '25 22:05 Kyle-Neale

Hey @michaelellwood is this still being worked on? If so, do you need any guidance in the PR?

Hey, thanks for response. Yes, this is complete. Is there anything else I need to do get this to reviewed and merged?

Thanks!

michaelellwood avatar Jun 02 '25 18:06 michaelellwood

Closing as this PR was merged: https://github.com/DataDog/integrations-core/pull/20598

sarah-witt avatar Jul 09 '25 17:07 sarah-witt