integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[SAASINT-4161] New Integration for Workato: Initial manifest as first step in provisioning

Open bskinny opened this issue 8 months ago • 5 comments

What does this PR do?

This minimal manifest is needed for the first step in provisioning the crawler based Workato integration.

Motivation

To be integrated on behalf of Datadog.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

bskinny avatar May 14 '25 22:05 bskinny

PR Security Update

All commits in this PR up to and including e0b3cce have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack.

cit-pr-commenter[bot] avatar May 15 '25 07:05 cit-pr-commenter[bot]

@michellealbright12 @apiazza-dd Thanks, made the fixes. Also updated the Install instructions if you want to take a gander.

bskinny avatar Jun 11 '25 18:06 bskinny

Thanks @urseberry !

bskinny avatar Jun 16 '25 12:06 bskinny

@bskinny - Thanks, it looks like there are some asset and manifest failures, can you please resolve and let me know? Thanks!

apiazza-dd avatar Jun 16 '25 14:06 apiazza-dd

@apiazza-dd Thanks, down to just one failure. This is my first no-assets PR, let me know if I am not following the process.

Run ddev validate labeler
labeler
└── /home/runner/work/integrations-core/integrations-core/.github/workflows/conf
    ig/labeler.yml
    
    Check `workato` does not have an integration PR label

Errors: 1
Try running `ddev validate labeler --sync`
Error: Process completed with exit code 1.

bskinny avatar Jun 16 '25 18:06 bskinny

@bskinny Yes you should install ddev (instructions here https://docs.datadoghq.com/developers/integrations/python/?tab=macos) and run that labeler command.

cmlaverdiere avatar Jun 17 '25 19:06 cmlaverdiere

@cmlaverdiere I was able to run the ddev command locally but it made no noticeable change, no change to labeler.yml for instance.

[I] brianww@Brians-iMac-2 ~/b/d/integrations-core (external-pr/workato)> ddev validate labeler --sync
Adding config for `workato`
Successfully fixed /Users/brianww/github/integrations-core/.github/workflows/config/labeler.yml
labeler

Labeler configuration is valid

And I do not have permission to push a manual change to .github/workflows/config/labeler.yml to include workato.

Any idea what I should do?

bskinny avatar Jun 17 '25 20:06 bskinny

@bskinny Looks like all of the checks are passing - getting reapprovals from docs team and then will merge. Thanks for your patience and great job on your first asset PR!

apiazza-dd avatar Jun 19 '25 12:06 apiazza-dd

Thanks @apiazza-dd !

bskinny avatar Jun 20 '25 12:06 bskinny