DDS: Trend Micro Vison One Endpoint Security: Crawler Integration Without Assets
What does this PR do?
PR includes skeleton of Trend Micro Vision One Endpoint Security integration without any assets like dashboards, image, README content, etc.
Motivation
This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanandersen's suggestion, we are planning to raise separate PR with assets and all necessary information later.
Additional Notes
Only crawler-based integration related changes are included in this PR.
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] Changelog entries must be created for modifications to shipped code
- [ ] Add the
qa/skip-qalabel if the PR doesn't need to be tested during QA. - [ ] If you need to backport this PR to another branch, you can add the
backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged
Hi @shubhamvekariya-crest as this integration looks incomplete, I'm adding the Work In progress label, once the README is completed with the rest of the required information, please remove the WIP label for another review. Thanks!
Hi @aliciascott, Nathan suggested raising this no-asset PR to help the Crawler team deploy the code faster after review for testing and other purposes. We have raised a separate PR with assets here. Could you please remove the WIP label so that the review process can move forward?
Hi @shubhamvekariya-crest as this integration looks incomplete, I'm adding the Work In progress label, once the README is completed with the rest of the required information, please remove the WIP label for another review. Thanks!
Hi @aliciascott, Nathan suggested raising this no-asset PR to help the Crawler team deploy the code faster after review for testing and other purposes. We have raised a separate PR with assets here. Could you please remove the WIP label so that the review process can move forward?
Sure, thanks for clarifying! I have removed the WIP label.
@aliciascott the "display_on_public_website" flag is off for this since the goal for now is simply to get an integration tile in place for org 2. sorry for the noise. can you remove your change request?
@aliciascott the "display_on_public_website" flag is off for this since the goal for now is simply to get an integration tile in place for org 2. sorry for the noise. can you remove your change request?
Hi @nathanmadams did you mean to send this to the author of the PR ? I can revert my stale review if that is what you meant? Sorry just let me know :)
@aliciascott i just pushed a new commit that made your original review stale which achieved the same thing so i think we're all good now. thanks!