integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

DDS: Trend Micro Vison One Endpoint Security: Crawler Integration Without Assets

Open shubhamvekariya-crest opened this issue 1 year ago • 2 comments

What does this PR do?

PR includes skeleton of Trend Micro Vision One Endpoint Security integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanandersen's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

shubhamvekariya-crest avatar Aug 14 '24 12:08 shubhamvekariya-crest

Hi @shubhamvekariya-crest as this integration looks incomplete, I'm adding the Work In progress label, once the README is completed with the rest of the required information, please remove the WIP label for another review. Thanks!

Hi @aliciascott, Nathan suggested raising this no-asset PR to help the Crawler team deploy the code faster after review for testing and other purposes. We have raised a separate PR with assets here. Could you please remove the WIP label so that the review process can move forward?

shubhamvekariya-crest avatar Aug 20 '24 11:08 shubhamvekariya-crest

Hi @shubhamvekariya-crest as this integration looks incomplete, I'm adding the Work In progress label, once the README is completed with the rest of the required information, please remove the WIP label for another review. Thanks!

Hi @aliciascott, Nathan suggested raising this no-asset PR to help the Crawler team deploy the code faster after review for testing and other purposes. We have raised a separate PR with assets here. Could you please remove the WIP label so that the review process can move forward?

Sure, thanks for clarifying! I have removed the WIP label.

git-thuerk-done avatar Aug 20 '24 14:08 git-thuerk-done

@aliciascott the "display_on_public_website" flag is off for this since the goal for now is simply to get an integration tile in place for org 2. sorry for the noise. can you remove your change request?

nathanmadams avatar Sep 06 '24 20:09 nathanmadams

@aliciascott the "display_on_public_website" flag is off for this since the goal for now is simply to get an integration tile in place for org 2. sorry for the noise. can you remove your change request?

Hi @nathanmadams did you mean to send this to the author of the PR ? I can revert my stale review if that is what you meant? Sorry just let me know :)

git-thuerk-done avatar Sep 06 '24 20:09 git-thuerk-done

@aliciascott i just pushed a new commit that made your original review stale which achieved the same thing so i think we're all good now. thanks!

nathanmadams avatar Sep 06 '24 20:09 nathanmadams