integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

feat: add apiserver_admission_webhook_request_total metric

Open jwillker opened this issue 1 year ago • 3 comments

What does this PR do?

This PR adds a new kubernetes metric: apiserver_admission_webhook_request_total More details: https://kubernetes.io/docs/reference/instrumentation/metrics/

This metric was created in the kubernetes 1.23 version: https://github.com/kubernetes/kubernetes/pull/103162

Fix: https://github.com/DataDog/integrations-core/issues/17689

Motivation

This metric is missing in the Datadog Kubernetes integration.

Additional Notes

Review checklist (to be filled by reviewers)

  • [x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [x] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

jwillker avatar May 31 '24 17:05 jwillker

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.80%. Comparing base (4013d3c) to head (2985228). Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
dotnetclr ?
gitlab ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kube_apiserver_metrics 97.75% <100.00%> (+0.01%) :arrow_up:
kubeflow ?
kubevirt_api ?
kubevirt_controller ?
marklogic ?
presto ?
snmp ?
solr ?
vertica ?
windows_service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 31 '24 21:05 codecov[bot]

@FlorentClarret I don't understand what is wrong with the tests. Can you help me?

jwillker avatar Jun 11 '24 22:06 jwillker

Would anyone be able to help me with this PR?

@Kyle-Neale, @jmeunier28, @dkirov-dd or someone else?

jwillker avatar Aug 23 '24 18:08 jwillker