integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Decrease database instance collection interval

Open sethsamuel opened this issue 1 year ago • 2 comments

What does this PR do?

Reduces collection interval from 30 minutes to 5 minutes for database instances.

Motivation

This change makes it less likely that a database instance will be incorrectly deleted from our stores, and improves the responsiveness of updates to database instances. This is intended to counteract bugs where databases are disappearing and causing tag flapping, as well as improving user experience with seeing the database instances they expect.

Additional Notes

Database instance events are fairly lightweight so no noticeable performance impact is expected.

Review checklist (to be filled by reviewers)

  • [x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [x] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [x] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

sethsamuel avatar May 07 '24 19:05 sethsamuel

Test Results

   16 files     16 suites   20m 32s :stopwatch:   286 tests   284 :white_check_mark:   2 :zzz: 0 :x: 2 296 runs  2 181 :white_check_mark: 115 :zzz: 0 :x:

Results for commit 65f70ff2.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

@sethsamuel Why no changelog and why we need to backport to 7.54?

lu-zhengda avatar May 07 '24 21:05 lu-zhengda