integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

remove Logs from Active Directory docs

Open shanelhuang opened this issue 1 year ago • 4 comments

What does this PR do?

removing references to Logs feature that doesn't exist, undoing this PR: https://github.com/DataDog/integrations-core/pull/1813/files

Motivation

https://datadoghq.atlassian.net/browse/WINA-649

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

shanelhuang avatar Feb 13 '24 12:02 shanelhuang

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Feb 13 '24 12:02 github-actions[bot]

👋 The config file is generated from the spec.yaml file. Could you also remove this section?

https://github.com/DataDog/integrations-core/blob/80088d1def734351054de0069227b3f48b0ec796/active_directory/assets/configuration/spec.yaml#L21-L26

Thanks!

done!

shanelhuang avatar Feb 13 '24 13:02 shanelhuang

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e5a9a09) 90.55% compared to head (25da570) 90.68%. Report is 59 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) :arrow_up:
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 13 '24 13:02 codecov[bot]

Test Results

2 files  2 suites   2s :stopwatch: 2 tests 2 :white_check_mark: 0 :zzz: 0 :x: 4 runs  2 :white_check_mark: 2 :zzz: 0 :x:

Results for commit 25da5705.

github-actions[bot] avatar Feb 13 '24 13:02 github-actions[bot]