integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Remove unnecessary `poll` method

Open alopezz opened this issue 3 years ago • 1 comments

What does this PR do?

Removes poll method as it's redundant.

Motivation

QA for #12776.

The headers are already being set on parse_config which also includes the logic to add the token to the header only if the no_token config is set to false. poll was overwriting the headers and therefore has duplicate logic.

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

alopezz avatar Sep 20 '22 13:09 alopezz

Codecov Report

Merging #12979 (c194e6d) into master (4a3ec76) will increase coverage by 0.01%. The diff coverage is n/a.

Flag Coverage Δ
vault 95.46% <ø> (+1.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 20 '22 13:09 codecov[bot]