integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Add Windows service `startup_type` filter to config

Open clarkb7 opened this issue 3 years ago • 1 comments

What does this PR do?

Adds a new startup_type pattern to the windows_service services config entry that enables users to filter services by their startup type at the agent.

This new pattern combines with the existing patterns

# Matches the EventLog service
services:
  - EventLog
services:
  - name: EventLog

# Matches all services with an automatic startup type
services:
  - startup_type: ^automatic$

# Only matches EventLog service when its startup type is automatic
services:
  - name: EventLog
    startup_type: ^automatic$

Motivation

https://datadoghq.atlassian.net/browse/WA-77

builds upon https://github.com/DataDog/integrations-core/pull/12932 by providing a way to filter the startup type at the agent to reduce bandwidth usage and unwanted service checks from showing in the dashboard.

Combining this with the windows_service_startup_type tag can be useful for separating service checks by their startup type in Monitors, for an example like the following

# Matches all services with an automatic startup type as well as remoteregistry regardless of it's startup type
services:
  - name: remoteregistry
  - startup_type: ^automatic$

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

clarkb7 avatar Sep 15 '22 18:09 clarkb7

Codecov Report

Merging #12940 (f9e0c7f) into master (be04343) will increase coverage by 0.02%. The diff coverage is 99.45%.

Flag Coverage Δ
windows_service 98.00% <99.45%> (+2.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 15 '22 19:09 codecov[bot]