integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Add config spec and models

Open fanny-jiang opened this issue 3 years ago • 2 comments

What does this PR do?

Updates the prometheus check with config spec and models. It also uses the instance/default config template so that it will stay up to date with any new config options added to the base check.

Motivation

Community

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

fanny-jiang avatar Aug 08 '22 21:08 fanny-jiang

Codecov Report

Merging #12714 (5d53033) into master (776d6fd) will not change coverage. The diff coverage is n/a.

Flag Coverage Δ
prometheus 94.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 08 '22 21:08 codecov[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 15 '22 22:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Oct 03 '22 20:10 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Dec 07 '22 20:12 github-actions[bot]