integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Add new OOTB dashboard for Kube Scheduler

Open arapulido opened this issue 3 years ago • 0 comments

What does this PR do?

This PR updates the default overview Kube Scheduler dashboard.

To work correctly, it requires agent 7.39 as there are some fixes in the integration that are in main, but not yet released.

Motivation

Keep the integration and its dashboard up to date

Additional Notes

When testing, you can use the agent-dev image to get all the needed metrics.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

arapulido avatar Aug 05 '22 12:08 arapulido

Thanks !

The dashboard looks much more cleaner now. 💅

I added 2 small comments, and I have a general question: some widgets have a legend some other don't. What was your criteria to add a legend? should we add a legend on every widget?

My idea was that if the widget had some grouping, then I would add the legend. But I see that in general OOTB dashboards don't have legend, and it is cleaner, so I will remove it.

Do you have a preference on whether to add legends or not?

Also in the PR description you mention that. The dashboard requires agent 7.39. What does it means for users with older agent versions? some missing graphs?

They would see some of the widgets empty.

arapulido avatar Sep 01 '22 12:09 arapulido

@clamoriniere addressed your feedback and replied to your questions/comments

arapulido avatar Sep 01 '22 13:09 arapulido