dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore: specify test branch for parametric tests for TestDynamicConfigSampling

Open erikayasuda opened this issue 1 year ago • 3 comments

DO NOT MERGE THIS PR

This PR points the parametric tests to the erikayasuda/enable-dynamic-config-python on system-tests. After dd-trace-py 2.9.0 is released, we will delete this PR, and update the system tests to point to v2.9.0 instead of v2.9.0dev. This is just to sanity check that our dynamic sampling configuration works on the latest 2.9 changes.

Context in this PR: https://github.com/DataDog/system-tests/pull/2523

Checklist

  • [ ] Change(s) are motivated and described in the PR description
  • [ ] Testing strategy is described if automated tests are not included in the PR
  • [ ] Risks are described (performance impact, potential for breakage, maintainability)
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [ ] Documentation is included (in-code, generated user docs, public corp docs)
  • [ ] Backport labels are set (if applicable)
  • [ ] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

erikayasuda avatar Jun 04 '24 19:06 erikayasuda

Datadog Report

Branch report: erikayasuda/temp-test-branch-parametric-tests Commit report: 9cd9612 Test service: dd-trace-py

:white_check_mark: 0 Failed, 137147 Passed, 40839 Skipped, 8h 58m 14.87s Total duration (2h 13m 16.81s time saved)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.34%. Comparing base (9521c11) to head (9cd9612).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9478       +/-   ##
===========================================
- Coverage   75.95%   10.34%   -65.62%     
===========================================
  Files        1303     1273       -30     
  Lines      123939   122093     -1846     
===========================================
- Hits        94140    12631    -81509     
- Misses      29799   109462    +79663     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 04 '24 20:06 codecov-commenter

Benchmarks

Benchmark execution time: 2024-06-04 20:23:33

Comparing candidate commit 9cd9612bcf19213c6122e1b03c47cf1b9f0ca794 in PR branch erikayasuda/temp-test-branch-parametric-tests with baseline commit 9521c11295d2ae56794c537a5394f3624477a2d2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Jun 04 '24 20:06 pr-commenter[bot]