fix(flare): handle non-dict AGENT_CONFIG products from RC [backport 2.10]
Backport a482830bdec4414a29eaf292ca46f9d3c6fc2a5f from #10985 to 2.10.
Tracer flares were failing due to AGENT_CONFIG items possibly containing pure booleans, and not just dictionaries. Example:
AGENT_CONFIG=[True, {...config...}, ...]
This would break the flare because it would be expecting only dicts.
Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the library release note guidelines
- The change includes or references documentation updates if necessary
- Backport labels are set (if applicable)
Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking API changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: backport-10985-to-2.10
Commit report: 84f5d41
Test service: dd-trace-py
:white_check_mark: 0 Failed, 173294 Passed, 1968 Skipped, 9h 57m 37.23s Total duration (1h 19m 23.48s time saved)
Codecov Report
Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
Project coverage is 10.20%. Comparing base (
4d99cf0) to head (84f5d41). Report is 24 commits behind head on 2.10.
Additional details and impacted files
@@ Coverage Diff @@
## 2.10 #11062 +/- ##
===========================================
- Coverage 74.24% 10.20% -64.05%
===========================================
Files 1332 1313 -19
Lines 126730 125201 -1529
===========================================
- Hits 94096 12781 -81315
- Misses 32634 112420 +79786
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Blocked until this merges: https://github.com/DataDog/dd-trace-py/pull/11070
Benchmarks
Benchmark execution time: 2024-10-18 04:36:02
Comparing candidate commit 5182f54ce7a1d4cd9586a75e2ee5bd6527db72b8 in PR branch backport-10985-to-2.10 with baseline commit 93c2c4138d7c3603cc8badaeb9ac36a14e2db054 in branch 2.10.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.