dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

perf(profiling) remove profiler mutex

Open realFlowControl opened this issue 1 year ago • 2 comments

Description

This PR removes the Mutex around the Profiler instance. Additionally I moved the lifecycle management into the Profiler object itself.

PROF-9531

Reviewer checklist

  • [x] Test coverage seems ok.
  • [x] Appropriate labels assigned.

realFlowControl avatar Jun 14 '24 13:06 realFlowControl

Benchmarks

Benchmark execution time: 2024-08-26 20:29:10

Comparing candidate commit 36d746010c246ef8276339776a1fe8c667f6912a in PR branch florian/remove-mutex with baseline commit 73480426016db356926120465febc65e2b60e5cd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Jun 14 '24 13:06 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.07%. Comparing base (7348042) to head (36d7460). Report is 61 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2714      +/-   ##
============================================
+ Coverage     78.49%   81.07%   +2.57%     
  Complexity     2516     2516              
============================================
  Files           173      146      -27     
  Lines         18679    14650    -4029     
  Branches        975        0     -975     
============================================
- Hits          14662    11877    -2785     
+ Misses         3480     2773     -707     
+ Partials        537        0     -537     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.19% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7348042...36d7460. Read the comment docs.

codecov-commenter avatar Jun 26 '24 13:06 codecov-commenter

@morrisonlevi fixed the merge conflicts 🎉

realFlowControl avatar Jul 09 '24 10:07 realFlowControl

@morrisonlevi can you have another look?

realFlowControl avatar Aug 01 '24 12:08 realFlowControl