dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

[DO NOT MERGE] Try pure oxc for startup time

Open rochdev opened this issue 3 months ago • 3 comments

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

rochdev avatar Nov 11 '25 02:11 rochdev

Overall package size

Self size: 13.22 MB Deduped: 121.41 MB No deduping: 136.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | meriyah | 6.1.4 | 1.41 MB | 1.41 MB | | oxc-parser | 0.96.0 | 1.35 MB | 1.4 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | esquery | 1.6.0 | 1.04 MB | 1.07 MB | | source-map-support | 0.5.21 | 85.18 kB | 895.45 kB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | escodegen | 2.1.0 | 108.55 kB | 510.59 kB | | @datadog/openfeature-node-server | 0.1.0-preview.15 | 106.53 kB | 424.55 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Nov 11 '25 02:11 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 78.73%. Comparing base (5ab5575) to head (e129ff2). :warning: Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
- Coverage   83.85%   78.73%   -5.13%     
==========================================
  Files         506      372     -134     
  Lines       21353    17105    -4248     
==========================================
- Hits        17905    13467    -4438     
- Misses       3448     3638     +190     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 11 '25 02:11 codecov[bot]

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

Plugin node:http/server canceled request should send traces to agent from canceled request (Datadog)
expected stub to not have been called

AssertionError: expected stub to not have been called
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-http/test/server.spec.js:69:43
    at handler (packages/dd-trace/test/plugins/agent.js:349:22)
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/dd-trace/test/plugins/agent.js:225:7
    at Set.forEach (<anonymous>)
    at handleTraceRequest (packages/dd-trace/test/plugins/agent.js:221:17)
    at /home/runner/work/dd-trace-js/dd-trace-js/packages/dd-trace/test/plugins/agent.js:429:7
    at Layer.handleRequest (node_modules/router/lib/layer.js:152:17)
...
Plugin node:http/server without configuration should run the request listener in the request scope from without configuration (Datadog)
expected spy to have been called exactly once with exact arguments {
  req: IncomingMessage {
    _events: {
      close: undefined,
      error: undefined,
      data: undefined,
      end: undefined,
      readable: undefined
    },
    _readableState: ReadableState {
...

🧪 1240 Tests failed

with express >=4.0.0  from Api Security (Datadog)
Cannot read properties of undefined (reading 'close')

TypeError: Cannot read properties of undefined (reading 'close')
    at Context.<anonymous> (packages/dd-trace/test/appsec/index.express.plugin.spec.js:296:14)
    at process.processImmediate (node:internal/timers:476:21)
with express >=4.0.0  from Api Security (Datadog)
require() of ES Module /home/runner/work/dd-trace-js/dd-trace-js/node_modules/oxc-parser/src-js/index.js from /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-instrumentations/src/helpers/rewriter/index.js not supported.
Instead change the require of /home/runner/work/dd-trace-js/dd-trace-js/node_modules/oxc-parser/src-js/index.js in /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-instrumentations/src/helpers/rewriter/index.js to a dynamic import() which is available in all CommonJS modules.

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/dd-trace-js/dd-trace-js/node_modules/oxc-parser/src-js/index.js from /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-instrumentations/src/helpers/rewriter/index.js not supported.
Instead change the require of /home/runner/work/dd-trace-js/dd-trace-js/node_modules/oxc-parser/src-js/index.js in /home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-instrumentations/src/helpers/rewriter/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (node_modules/append-transform/index.js:64:4)
    at Object.<anonymous> (packages/datadog-instrumentations/src/helpers/rewriter/index.js:22:13)
    at Module.replacementCompile (node_modules/append-transform/index.js:60:13)
    at Object.<anonymous> (node_modules/append-transform/index.js:64:4)
    at Object.<anonymous> (packages/datadog-instrumentations/src/helpers/register.js:13:18)
...
with express >=4.0.0  from Api Security (Datadog)
Cannot read properties of undefined (reading 'close')

TypeError: Cannot read properties of undefined (reading 'close')
    at Context.<anonymous> (packages/dd-trace/test/appsec/index.express.plugin.spec.js:296:14)
    at process.processImmediate (node:internal/timers:476:21)
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e129ff2 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

datadog-official[bot] avatar Nov 11 '25 02:11 datadog-official[bot]