dd-sdk-android icon indicating copy to clipboard operation
dd-sdk-android copied to clipboard

RUM-4098: Use the datastore for Session Replay resources

Open jonathanmos opened this issue 1 year ago • 1 comments

What does this PR do?

Use the datastore from Session Replay, so that resource hashes are persisted between sessions.

Motivation

The second part of the effort to persist bitmap hashes between sessions.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • [ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

jonathanmos avatar May 20 '24 13:05 jonathanmos

Codecov Report

Attention: Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (d8d0838) to head (fa9f3b1). Report is 1 commits behind head on develop.

:exclamation: Current head fa9f3b1 differs from pull request most recent head 4641fbf

Please upload reports for the commit 4641fbf to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2041       +/-   ##
============================================
+ Coverage    69.56%   83.22%   +13.67%     
============================================
  Files          715      511      -204     
  Lines        26553    18119     -8434     
  Branches      4452     2719     -1733     
============================================
- Hits         18469    15079     -3390     
+ Misses        6871     2293     -4578     
+ Partials      1213      747      -466     
Files Coverage Δ
...rnal/persistence/datastore/DataStoreFileHandler.kt 100.00% <100.00%> (ø)
...ernal/persistence/datastore/DatastoreFileReader.kt 95.56% <ø> (ø)
...rnal/persistence/datastore/NoOpDataStoreHandler.kt 100.00% <ø> (ø)
.../sessionreplay/internal/DefaultRecorderProvider.kt 93.10% <100.00%> (+0.06%) :arrow_up:
...oid/sessionreplay/internal/SessionReplayFeature.kt 100.00% <100.00%> (ø)
...replay/internal/processor/RecordedDataProcessor.kt 97.67% <100.00%> (+0.17%) :arrow_up:
...nreplay/internal/recorder/SessionReplayRecorder.kt 96.69% <100.00%> (-0.11%) :arrow_down:
...ernal/resources/ResourceHashesEntryDeserializer.kt 100.00% <100.00%> (ø)
...nternal/resources/ResourceHashesEntrySerializer.kt 50.00% <50.00%> (ø)
.../android/api/storage/datastore/DataStoreHandler.kt 20.00% <0.00%> (-13.33%) :arrow_down:
... and 2 more

... and 265 files with indirect coverage changes

codecov-commenter avatar May 21 '24 08:05 codecov-commenter