Possibly Incorrect Default Unix Socket Path

[daviddyball]

Describe what happened: Provisioning new DatadogAgent resources with spec.agent.apm.unixDomainSocket.enabled: true creates a socket under /var/run/datadog/apm.sock, which contradicts most client libraries default lookup path of /var/run/datadog/apm.socket (socket not sock).

Describe what you expected: I expected the DatadogAgent to provision using the correct socket path name

Steps to reproduce the issue: Provision any simple DatadogAgent v1alpha1 resource.

Additional environment details (Operating System, Cloud provider, etc):

datadog-operator version 0.8.1.

[chrispsplash]

Indeed, the datadog cluster agent notes explicitly state the default path ends with apm.socket. I worked around this by updating my DatadogAgent with agent.apm.unixDomainSocket.hostFilepath=/var/run/datadog/apm.socket to use the proper default

[AdamS3x]

Can this issue get some traction? We've hit the exact same problem and APM does not work without it which considering that Datadog now recommend datadog-operator as the preferred approach is poor really when the alternative is to not use the unix socket and instead open up port 8126 as a host port on the nodes which is insecure

[jcogilvie]

For what it's worth, the admission controller injects a value which matches the operator. Using it might simplify your configuration.

[levan-m]

Hello, sorry for not getting to the issue on time. Operator v0.x is no longer supported and we recommend migrating to most recent version of v1.x.

Please open a new issue if there is anything blocking migration or you experience same issue in v1.x.