DDAI Create strategy review suggestion
What does this PR do?
- Preserves createStrategy field over updates + updates lastTransition there only when there's a change
- Update tests
Motivation
- Matching DDA behaviour
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
- Agent: vX.Y.Z
- Cluster Agent: vX.Y.Z
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
- [ ] PR has at least one valid label:
bug,enhancement,refactoring,documentation,tooling, and/ordependencies - [ ] PR has a milestone or the
qa/skip-qalabel
Codecov Report
:x: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 37.10%. Comparing base (09cb5c0) to head (39c2b5b).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/agentprofile/agent_profile.go | 85.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## khewonc/create-strategy-ddai #2407 +/- ##
================================================================
+ Coverage 37.07% 37.10% +0.03%
================================================================
Files 288 288
Lines 24553 24566 +13
================================================================
+ Hits 9102 9115 +13
Misses 14739 14739
Partials 712 712
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 37.10% <85.71%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/agentprofile/status.go | 67.53% <100.00%> (ø) |
|
| pkg/agentprofile/agent_profile.go | 73.80% <85.00%> (+0.88%) |
:arrow_up: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 09cb5c0...39c2b5b. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.