datadog-operator icon indicating copy to clipboard operation
datadog-operator copied to clipboard

Add cluster name to all v2alpha examples

Open dogeahill opened this issue 1 year ago • 1 comments

What does this PR do?

Add clusterName to all v2alpha examples.

Motivation

While implementing on Azure Redhat OpenShift, we used the example and had to add clusterName to properly view the data in our Kubernetes Overview page.

It is a known issue that without the clusterName, the Kubernetes explorer will not be useful as nothing will show besides the container view.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • [ ] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • [ ] PR has a milestone or the qa/skip-qa label

dogeahill avatar May 08 '24 16:05 dogeahill

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.55%. Comparing base (6b0c7bd) to head (fda3339).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   59.55%   59.55%           
=======================================
  Files         174      174           
  Lines       21559    21559           
=======================================
  Hits        12839    12839           
  Misses       7941     7941           
  Partials      779      779           
Flag Coverage Δ
unittests 59.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b0c7bd...fda3339. Read the comment docs.

codecov-commenter avatar May 08 '24 16:05 codecov-commenter

thank you @dogeahill

celenechang avatar May 16 '24 17:05 celenechang