datadog-api-client-python icon indicating copy to clipboard operation
datadog-api-client-python copied to clipboard
verified publisher icon DataDog

Upgrade aiosonic

Open hauntsaninja opened this issue 7 months ago • 9 comments

Currently datadog-api-client pins aiosonic==0.15.1 The current version is aiosonic 0.24.0

It was pinned for a reason related to onecache that no longer applies

hauntsaninja avatar May 26 '25 22:05 hauntsaninja

Quite a few nasty bugs have been fixed in aiosonic in the meantime:

  • https://github.com/sonic182/aiosonic/issues/473
  • https://github.com/sonic182/aiosonic/issues/448 I've been experiencing some cryptic bugs which I think are related.

I don't know why aiosonic was selected as the backbone for this library, but I'd reevaluate this dependency.

HaukurPall avatar May 27 '25 09:05 HaukurPall

I opened a PR for this over at https://github.com/DataDog/datadog-api-client-python/pull/2522 btw

hauntsaninja avatar May 28 '25 00:05 hauntsaninja

I am also seeing strange timeouts, likely related to connection handling. Upgrading means I would at least be able to exclude old aiosonic issues. For now I will interact directly with the Rest API using aiohttp.

calleo avatar May 31 '25 14:05 calleo

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

github-actions[bot] avatar Jul 03 '25 00:07 github-actions[bot]

The issue is still relevant

hauntsaninja avatar Jul 03 '25 00:07 hauntsaninja

cc @damfleu would it be possible to get a review or merge on https://github.com/DataDog/datadog-api-client-python/pull/2522 ?

hauntsaninja avatar Jul 03 '25 00:07 hauntsaninja

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

github-actions[bot] avatar Sep 02 '25 00:09 github-actions[bot]

Another good reason to update this is to import security fixes from transitive dependencies (e.g., aiosonic relying on h2: https://github.com/python-hyper/h2/security/advisories/GHSA-847f-9342-265h).

phosphore avatar Nov 03 '25 11:11 phosphore

Hi,

I'm the author of aiosonic, very happy of seeing the package in datadog ❤️

The most important fix was made in 0.22.3 https://github.com/sonic182/aiosonic/blob/master/CHANGELOG.md#0223-2025-02-10 that caused a lot of problems, you should be ok with any version after it

A note: it seems that you use proxy (if configured) it didn't work for https before 0.18.1

sonic182 avatar Nov 12 '25 22:11 sonic182