Cannot create MFA Token Global Variables

[mpistrang]

The low level API for /api/v1/synthetics/variables allows for MFA Token Global Variables to be created, however this python library does not expose this functionality. The SyntheticsGlobalVariable model is lacking the is_totp boolean attribute required to create such variables. The same property is reflected back in the HTTP response. I should mention is_fido is also missing.

I've proven locally that adding the is_totp attribute to the model and OpenAPI spec allows MFA Token Global Variables to be created via this library. Is this a contribution that would be appreciated?

[Drarig29]

Hi @mpistrang! Thanks for reporting.

Indeed, adding the support for is_totp is the right thing to do...

But this repository is a downstream repository where most of the code is automatically generated according to our internal API specification, so we'll have to close your PR. We appreciate your effort though, and are sorry for the time you spent on it.

We made an internal card to tackle this in the best delays 🙇

[mpistrang]

Thanks for the info. The linked spec repo appears to be private, but I trust you will get this fixed soon. Thanks.

[github-actions[bot]]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.

[Drarig29]

Update: we are still working on it and in review process.

[Drarig29]

Update: https://github.com/DataDog/datadog-api-client-python/pull/2059 was merged. The next release will contain the changes!

[github-actions[bot]]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.