v1 synthetics incorrectly checks for a maximum limit of 1440 on renotify_interval

[mfarley281]

Line 19 @ datadog_api_client/v1/model/synthetics_test_options_monitor_options.py specifies a maximum of 1440 renotify_interval. However, in the datadog GUI, things have been updated to allow custom entries of > 1440 (24 hours). A user can enter 100 days for example.

The API fails on various operations when it interacts with a test that has a renotify_interval of more than 1440 (which is completely valid, thanks to new features in the Datadog GUI).

This is in reference to the "Enable renotification" option that says:

"If this monitor stays in alert status renotify every [ x ] [ minutes/hours/seconds/days ]

It used to only allow a maximum of 24 hours, but now allows a custom entry of any period of time.

The API needs to be updated to account for this.

[nkzou]

Hi, thanks for raising the issue, and apologies for the delay. I've confirmed the discrepancy and am in the process of confirming with the api owners what a new reasonable limit is - hope to have an update for you soon.

[mfarley281]

Thanks Kevin!

Sent from my mobile phone

On Fri, Mar 22, 2024, 3:39 AM Kevin Zou @.***> wrote:

Hi, thanks for raising the issue, and apologies for the delay. I've confirmed the discrepancy and am in the process of confirming with the api owners what a new reasonable limit is - hope to have an update for you soon.

— Reply to this email directly, view it on GitHub https://github.com/DataDog/datadog-api-client-python/issues/1881#issuecomment-2013499434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJ4FN4EFKLCZHY7DH4EHBDYZMZPHAVCNFSM6AAAAABDWNRJKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGQ4TSNBTGQ . You are receiving this because you authored the thread.Message ID: @.***>

[github-actions[bot]]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.

[github-actions[bot]]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.

[mfarley281]

I think this is still an issue

[github-actions[bot]]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.

[nkzou]

Hi, v2.26.0 was released yesterday and should contain the relevant fix for this issue - please try it out and let us know if this is still an issue.