datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Laura.hampton/update metric origins

Open lgh2 opened this issue 1 year ago • 3 comments

What does this PR do?

Updates metric origins for kyverno, anyscale, appgate_sdp, kubeflow, slurm, and tibco_ems

Motivation

Related to https://github.com/DataDog/dd-source/pull/121872

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

lgh2 avatar Aug 29 '24 19:08 lgh2

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Aug 29 '24 19:08 bits-bot

Regression Detector

Regression Detector Results

Run ID: 9c3a43c3-b3f8-402c-bc83-4308074ea19a Metrics dashboard Target profiles

Baseline: 6f76f1ed2ef850c09e9130a094e4aae58ab2e5cd Comparison: a961f89c55a1f3adcefc16baa58d67bfbfe7ff1c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +8.21 [-5.23, +21.66] 1 Logs
basic_py_check % cpu utilization +1.22 [-1.54, +3.99] 1 Logs
otel_to_otel_logs ingress throughput +0.78 [-0.03, +1.59] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.13 [-0.73, +0.99] 1 Logs
file_tree memory utilization +0.03 [-0.02, +0.08] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
idle memory utilization -0.35 [-0.38, -0.31] 1 Logs
pycheck_lots_of_tags % cpu utilization -2.65 [-5.11, -0.19] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Aug 29 '24 22:08 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43683625 --os-family=ubuntu

Note: This applies to commit a961f89c

pr-commenter[bot] avatar Sep 03 '24 21:09 pr-commenter[bot]

/merge

Kyle-Neale avatar Sep 16 '24 14:09 Kyle-Neale

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 16 '24 14:09 dd-devflow[bot]