datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3776] Increase duration of TestSBOM and TestContainerImage and make sure the repodigest is there

Open AliDatadog opened this issue 1 year ago • 4 comments

What does this PR do?

This PR increases the duration of TestSBOM and TestContainerImage and makes sure that the repodigest is sent in the protobuf.

Motivation

Reduce test flakiness by making sure that at least a refresh has occurred

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Run e2e tests. It should reduce flakiness

AliDatadog avatar Mar 15 '24 14:03 AliDatadog

/trigger-ci --variable RUN_E2E_TESTS=true

AliDatadog avatar Mar 15 '24 14:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #30182929

dd-devflow[bot] avatar Mar 15 '24 14:03 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30295435 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 15:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 6e0bda47-22ab-40f4-94d1-854adb8680db Baseline: 6c5fe04ebf61708de7ad4195d02e6914f5a63365 Comparison: b71bf9fc1b07e708ace88ce2cb13706af22f5a05

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.11 [-5.33, +7.55]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.11 [-5.33, +7.55]
pycheck_1000_100byte_tags % cpu utilization +0.32 [-4.62, +5.26]
otel_to_otel_logs ingress throughput +0.25 [-0.18, +0.68]
idle memory utilization +0.09 [+0.06, +0.13]
trace_agent_msgpack ingress throughput +0.01 [+0.01, +0.02]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_standard_check memory utilization -0.02 [-0.05, +0.02]
trace_agent_json ingress throughput -0.02 [-0.07, +0.03]
process_agent_real_time_mode memory utilization -0.04 [-0.07, -0.01]
process_agent_standard_check_with_stats memory utilization -0.15 [-0.18, -0.12]
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.30, -0.14]
file_tree memory utilization -0.23 [-0.32, -0.13]
basic_py_check % cpu utilization -1.34 [-3.86, +1.18]
uds_dogstatsd_to_api_cpu % cpu utilization -3.25 [-5.98, -0.51]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 15:03 pr-commenter[bot]

[Fast Unit Tests Report]

Warning: On pipeline 30295435. The following jobs did not run any unit tests:

  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Closed as no failure was detected since a log client fix

AliDatadog avatar Apr 08 '24 09:04 AliDatadog