datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[usm] Add debugger binary

Open p-lambert opened this issue 1 year ago • 2 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

p-lambert avatar Mar 14 '24 16:03 p-lambert

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33050077 --os-family=ubuntu

pr-commenter[bot] avatar Mar 14 '24 17:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: abd8b2bd-505a-4a4c-9757-c03b3fa74d7e Baseline: 5f2bf3e020d71cf3bbfb2ebeac518a3ebefaa314 Comparison: e10c4d1d1b7b6dcffc5b1e3e2bb327e07f94b9ef

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -32.81 [-38.74, -26.87]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +21.28 [-1.95, +44.50]
pycheck_1000_100byte_tags % cpu utilization +1.82 [-2.90, +6.54]
basic_py_check % cpu utilization +0.73 [-1.66, +3.12]
otel_to_otel_logs ingress throughput +0.06 [-0.31, +0.42]
tcp_dd_logs_filter_exclude ingress throughput +0.04 [+0.00, +0.07]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.12 [-0.17, -0.07]
idle memory utilization -0.18 [-0.22, -0.15]
uds_dogstatsd_to_api_cpu % cpu utilization -0.35 [-3.29, +2.58]
process_agent_standard_check_with_stats memory utilization -0.36 [-0.41, -0.31]
process_agent_standard_check memory utilization -0.38 [-0.44, -0.32]
file_to_blackhole % cpu utilization -32.81 [-38.74, -26.87]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 14 '24 18:03 pr-commenter[bot]