datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Improve how KMT jobs are scheduled in the CI

Open gjulianm opened this issue 1 year ago • 7 comments

What does this PR do?

  • Run KMT jobs when the tasks files change
  • Add RUN_KMT_TESTS variable to force running KMT jobs if needed.

Motivation

Ensure that changes in those files trigger a CI run for the corresponding job.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

gjulianm avatar Mar 13 '24 15:03 gjulianm

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1efba971-615b-40f8-aa8f-dd51ad0569dc Baseline: 2b5bbee1959ca2ac23f0c519312bad431c40fc36 Comparison: f8d5e61c2779f4b02fcd8925598a95bde8b58511

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.76 [-7.31, +5.79]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +2.60 [-2.73, +7.92]
basic_py_check % cpu utilization +0.67 [-1.60, +2.94]
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.56, +0.76]
process_agent_standard_check memory utilization +0.59 [+0.56, +0.62]
idle memory utilization +0.09 [+0.05, +0.12]
trace_agent_msgpack ingress throughput +0.01 [+0.01, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
otel_to_otel_logs ingress throughput +0.00 [-0.42, +0.42]
trace_agent_json ingress throughput -0.04 [-0.08, -0.00]
file_tree memory utilization -0.12 [-0.17, -0.06]
process_agent_real_time_mode memory utilization -0.20 [-0.23, -0.17]
process_agent_standard_check_with_stats memory utilization -0.46 [-0.49, -0.43]
file_to_blackhole % cpu utilization -0.76 [-7.31, +5.79]
uds_dogstatsd_to_api_cpu % cpu utilization -1.52 [-4.41, +1.37]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 16:03 pr-commenter[bot]

/trigger-ci --variable RUN_KMT_TESTS=on

gjulianm avatar Mar 14 '24 08:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #30082949

dd-devflow[bot] avatar Mar 14 '24 08:03 dd-devflow[bot]

/trigger-ci --variable RUN_KMT_TESTS=on

gjulianm avatar Mar 14 '24 16:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #30114240

dd-devflow[bot] avatar Mar 14 '24 16:03 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30278749 --os-family=ubuntu

pr-commenter[bot] avatar Mar 14 '24 17:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 1426aca0-e0a2-4da6-a338-7228d65227a8 Baseline: c970533d2c7669bb15820c6ffc09ff7986fc4cb9 Comparison: 0b6ce64b80a9aeb1a8d6051edbea809887cc214b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +6.57 [-0.30, +13.44]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +6.57 [-0.30, +13.44]
pycheck_1000_100byte_tags % cpu utilization +1.04 [-3.84, +5.93]
tcp_syslog_to_blackhole ingress throughput +0.81 [+0.72, +0.90]
file_tree memory utilization +0.31 [+0.22, +0.41]
process_agent_standard_check_with_stats memory utilization +0.24 [+0.21, +0.27]
idle memory utilization +0.20 [+0.17, +0.23]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.03, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.01]
process_agent_standard_check memory utilization -0.02 [-0.06, +0.02]
trace_agent_json ingress throughput -0.03 [-0.08, +0.01]
otel_to_otel_logs ingress throughput -0.04 [-0.49, +0.42]
process_agent_real_time_mode memory utilization -0.07 [-0.11, -0.04]
basic_py_check % cpu utilization -1.10 [-3.49, +1.28]
uds_dogstatsd_to_api_cpu % cpu utilization -1.19 [-3.91, +1.54]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 14 '24 17:03 pr-commenter[bot]

[Fast Unit Tests Report]

Warning: On pipeline 30278749. The following jobs did not run any unit tests:

  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/trigger-ci --variable RUN_KMT_TESTS=on

gjulianm avatar Mar 18 '24 10:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #30278749

dd-devflow[bot] avatar Mar 18 '24 10:03 dd-devflow[bot]

/merge

gjulianm avatar Mar 18 '24 11:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 18 '24 11:03 dd-devflow[bot]