datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3931] Clean SBOM cache enabled option

Open AliDatadog opened this issue 1 year ago • 1 comments

What does this PR do?

This PR cleans the SBOM cache enabled option and does some cleanup in the SBOM cache code. It removes many layers of abstraction.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Enable SBOM collection of container images on helm with and without this option. Make sure that SBOMs are collected properly.

Note: we could not test without this option for now as it is already broken on main.

AliDatadog avatar Mar 13 '24 12:03 AliDatadog

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: d83d9450-d653-4896-b36e-3210ee62b36c Baseline: 25972295ec1c7c4230a31628d38b3e89bd852a32 Comparison: 843ac57700a3c22dfcf41c9823741abfcbceaf86

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.96 [-5.65, +7.57]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.06 [-0.34, +4.47]
file_to_blackhole % cpu utilization +0.96 [-5.65, +7.57]
process_agent_standard_check_with_stats memory utilization +0.75 [+0.71, +0.78]
idle memory utilization +0.39 [+0.35, +0.42]
tcp_syslog_to_blackhole ingress throughput +0.33 [+0.23, +0.44]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
otel_to_otel_logs ingress throughput -0.00 [-0.40, +0.40]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
trace_agent_json ingress throughput -0.02 [-0.05, +0.00]
uds_dogstatsd_to_api_cpu % cpu utilization -0.05 [-2.92, +2.83]
process_agent_standard_check memory utilization -0.06 [-0.10, -0.03]
process_agent_real_time_mode memory utilization -0.20 [-0.23, -0.16]
file_tree memory utilization -0.45 [-0.51, -0.39]
pycheck_1000_100byte_tags % cpu utilization -0.76 [-5.96, +4.45]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 17:03 pr-commenter[bot]

/merge

AliDatadog avatar Mar 22 '24 14:03 AliDatadog

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 6 builds ahead! (estimated merge in less than 53m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 22 '24 14:03 dd-devflow[bot]