Revert "[CONTINT-3909] Add tests for dogstatsd origin detection on ECS"
#incident-25908
What does this PR do?
This PR reverts https://github.com/DataDog/datadog-agent/pull/23532 which breaks dogstatsd tests, due to the fact that we can't filter metrics by regexp.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
could you add the link to the PR that you revert?
Updated the PR description
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
/merge --cancel
:warning: MergeQueue
This merge request was unqueued
If you need support, contact us on Slack #ci-interfaces!
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 60d71712-4128-432c-8068-ff1f90efdc2e Baseline: af85149c182d2bed922a86577e47b11267704f95 Comparison: 67efc9e9ee8cbc0492c86472dcd35e6a825cbbea
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.12 | [-6.41, +6.65] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.49 | [+1.02, +3.96] |
| ➖ | basic_py_check | % cpu utilization | +1.83 | [-0.44, +4.09] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.44 | [+0.38, +0.49] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.41 | [+0.38, +0.45] |
| ➖ | idle | memory utilization | +0.25 | [+0.21, +0.28] |
| ➖ | process_agent_standard_check | memory utilization | +0.16 | [+0.12, +0.19] |
| ➖ | file_to_blackhole | % cpu utilization | +0.12 | [-6.41, +6.65] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.05 | [+0.03, +0.06] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.00, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | file_tree | memory utilization | -0.02 | [-0.10, +0.05] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.48 | [-0.51, -0.45] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.50 | [-1.11, +0.12] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 2 builds ahead! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!