datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Update OTLP benchmark test with large traces

Open liustanley opened this issue 2 years ago • 1 comments

What does this PR do?

Modifies existing benchmark test for processRequest and ReceiveResourceSpans for larger trace payloads.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

This benchmark test can be run in pkg/trace/api with the following command:

❯ go test -run=XXX -bench=BenchmarkProcessRequest -tags=test
goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/trace/api
BenchmarkProcessRequest-10    	     141	   8413292 ns/op	10020732 B/op	    8313 allocs/op
PASS
ok  	github.com/DataDog/datadog-agent/pkg/trace/api	2.674s

liustanley avatar Mar 08 '24 18:03 liustanley

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 5a1a714e-7bd6-4748-9edc-20a82741de4f Baseline: ee6d7eec560b850d02731423b9e14c5d6fa1cf48 Comparison: 085313eb920a68f443e5e3bfb0c1f4e4188b35f4

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.37 [-6.22, +6.95]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.09 [+0.62, +3.55]
basic_py_check % cpu utilization +1.73 [-0.60, +4.06]
otel_to_otel_logs ingress throughput +0.50 [-0.10, +1.11]
process_agent_real_time_mode memory utilization +0.45 [+0.42, +0.48]
file_to_blackhole % cpu utilization +0.37 [-6.22, +6.95]
process_agent_standard_check memory utilization +0.35 [+0.32, +0.39]
tcp_syslog_to_blackhole ingress throughput +0.23 [+0.18, +0.29]
process_agent_standard_check_with_stats memory utilization +0.18 [+0.16, +0.21]
idle memory utilization +0.10 [+0.07, +0.13]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
trace_agent_json ingress throughput +0.00 [-0.03, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
file_tree memory utilization -0.15 [-0.22, -0.08]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 08 '24 20:03 pr-commenter[bot]

/merge

liustanley avatar Mar 11 '24 15:03 liustanley

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 11 '24 15:03 dd-devflow[bot]