datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[run-pipeline-message] Added notify task for github commenter

Open CelianR opened this issue 1 year ago • 2 comments

What does this PR do?

Adds a PR commenter in datadog-agent pipeline that gives instruction that can be copy pasted to tests a dev-branch pipeline version, similarly to what web-ui does with hashlinks.

Concretely, it adds a comment :

inv create-vm --pipeline-id=<pipeline_id>

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

CelianR avatar Mar 08 '24 16:03 CelianR

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30020024 --os-family=ubuntu

pr-commenter[bot] avatar Mar 11 '24 13:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 509c8ddc-a1ce-4891-b05a-04d5201e4021 Baseline: 7550117fa81ba6c32ed04d82e1fa3d99f30b79f7 Comparison: 0248c101ad05d31e29a0b4a010cbc303827a6744

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.06 [-6.50, +6.62]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +3.02 [+2.91, +3.13]
idle memory utilization +0.92 [+0.89, +0.95]
tcp_syslog_to_blackhole ingress throughput +0.89 [+0.83, +0.94]
process_agent_standard_check_with_stats memory utilization +0.57 [+0.54, +0.60]
process_agent_standard_check memory utilization +0.29 [+0.25, +0.32]
process_agent_real_time_mode memory utilization +0.23 [+0.19, +0.27]
file_to_blackhole % cpu utilization +0.06 [-6.50, +6.62]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.04, +0.00]
otel_to_otel_logs ingress throughput -0.41 [-1.06, +0.24]
uds_dogstatsd_to_api_cpu % cpu utilization -0.81 [-2.24, +0.62]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 11 '24 14:03 pr-commenter[bot]

/merge

CelianR avatar Mar 13 '24 08:03 CelianR

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 13 '24 08:03 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 13 '24 08:03 dd-devflow[bot]

/merge

CelianR avatar Mar 13 '24 12:03 CelianR

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 13 '24 12:03 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 13 '24 12:03 dd-devflow[bot]

/merge

CelianR avatar Mar 13 '24 14:03 CelianR

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 13 '24 14:03 dd-devflow[bot]