[CONTINT-3760] Minor code improvements in SBOM scanner

[AliDatadog]

What does this PR do?

This PR contains minor code improvements in the SBOM scanner.

We call scan.Done() only once. Remove some indentations. Remove code duplication.

Motivation

Improve code quality

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

No additionnal test for this card. It's a follow up of https://github.com/DataDog/datadog-agent/pull/23323

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 41a7fe40-a4fd-4afd-801d-24885c65a053 Baseline: 88181b875f1b3d926cc6342e1b88fd923a449728 Comparison: 5cebc1a4c1dda40a2d5a419de0598b7844431f27

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.18	[-6.36, +6.72]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	otel_to_otel_logs	ingress throughput	+2.33	[+1.68, +2.98]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.98	[+0.52, +3.44]
➖	process_agent_real_time_mode	memory utilization	+1.11	[+1.06, +1.15]
➖	idle	memory utilization	+0.89	[+0.84, +0.95]
➖	file_to_blackhole	% cpu utilization	+0.18	[-6.36, +6.72]
➖	process_agent_standard_check_with_stats	memory utilization	+0.03	[-0.02, +0.07]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.02]
➖	trace_agent_msgpack	ingress throughput	-0.02	[-0.03, -0.01]
➖	file_tree	memory utilization	-0.12	[-0.23, -0.02]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.40	[-0.45, -0.34]
➖	process_agent_standard_check	memory utilization	-0.48	[-0.51, -0.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[AliDatadog]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!