datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[EBPF-294] Add Oracle images to KMT

Open gjulianm opened this issue 1 year ago • 10 comments

What does this PR do?

Adds Oracle 7.9 (x64 only), 8.9 and 9.3 to KMT.

Motivation

Bringing the KMT test images as close to Kitchen as possible for security-agent tests.

Related: https://github.com/DataDog/ami-builder/pull/159 https://datadoghq.atlassian.net/browse/EBPF-294

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

gjulianm avatar Mar 06 '24 12:03 gjulianm

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1ec375f3-8d04-43e9-a1af-7c5c788d1d91 Baseline: 4666ca6225a49fbb7fbc8a9f9bc6b23770565586 Comparison: 31c4a28d817db4cd50e5b75ab9db67f89c469661

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.90 [-7.43, +5.63]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +1.47 [+1.40, +1.53]
process_agent_real_time_mode memory utilization +0.89 [+0.85, +0.92]
uds_dogstatsd_to_api_cpu % cpu utilization +0.59 [-0.86, +2.05]
process_agent_standard_check memory utilization +0.33 [+0.30, +0.37]
idle memory utilization +0.10 [+0.06, +0.13]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
process_agent_standard_check_with_stats memory utilization -0.01 [-0.04, +0.02]
otel_to_otel_logs ingress throughput -0.34 [-1.00, +0.32]
file_tree memory utilization -0.67 [-0.75, -0.58]
file_to_blackhole % cpu utilization -0.90 [-7.43, +5.63]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 06 '24 13:03 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on

gjulianm avatar Mar 08 '24 14:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #29802387

dd-devflow[bot] avatar Mar 08 '24 14:03 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on

gjulianm avatar Mar 08 '24 16:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #29815690

dd-devflow[bot] avatar Mar 08 '24 16:03 dd-devflow[bot]

/trigger-ci --watch

gjulianm avatar Mar 11 '24 11:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #29882448

dd-devflow[bot] avatar Mar 11 '24 11:03 dd-devflow[bot]

:steam_locomotive: Devflow: /trigger-ci --watch

dd-devflow[bot] avatar Mar 11 '24 11:03 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30469507 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 14:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 45aad430-5a09-409c-9741-1b2490831b32 Baseline: 6e0f9feefe1686ae5979deef6d5c8edfd792c6ae Comparison: 5fc661c56d1b851f26314d30a38ebbacb9db63ec

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.57 [-8.84, +3.70]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.88 [-1.81, +3.57]
pycheck_1000_100byte_tags % cpu utilization +0.24 [-4.67, +5.15]
file_tree memory utilization +0.10 [+0.01, +0.20]
trace_agent_msgpack ingress throughput +0.03 [+0.01, +0.05]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_json ingress throughput -0.00 [-0.03, +0.03]
process_agent_real_time_mode memory utilization -0.01 [-0.05, +0.03]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.05, +0.01]
process_agent_standard_check memory utilization -0.13 [-0.17, -0.10]
otel_to_otel_logs ingress throughput -0.21 [-0.65, +0.23]
process_agent_standard_check_with_stats memory utilization -0.26 [-0.29, -0.22]
basic_py_check % cpu utilization -0.27 [-2.77, +2.24]
idle memory utilization -0.33 [-0.37, -0.29]
tcp_syslog_to_blackhole ingress throughput -0.66 [-0.75, -0.58]
file_to_blackhole % cpu utilization -2.57 [-8.84, +3.70]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 14:03 pr-commenter[bot]

/trigger-ci

gjulianm avatar Mar 20 '24 10:03 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #30432184

dd-devflow[bot] avatar Mar 20 '24 10:03 dd-devflow[bot]

[Fast Unit Tests Report]

On pipeline 30469507 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/merge

gjulianm avatar Mar 21 '24 10:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 21 '24 10:03 dd-devflow[bot]