Remove init function and global variable in `pkg/util/retry`
What does this PR do?
Remove global variable and init function of the pkg/util/retry package.
Motivation
Reduce serverless agent init duration. The package took between 1 and 3.5ms to initialize that global map.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: dbda242a-e7e8-4344-8bd0-d7c5f3937c32 Baseline: 1502319de6e007efa56e554410a4d753fc76e198 Comparison: d29718c52cd1cbd6383d34c53db24cc57838b126
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.04 | [-5.53, +7.62] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.04 | [-5.53, +7.62] |
| ➖ | file_tree | memory utilization | +0.52 | [+0.46, +0.59] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.53, +0.75] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.04 | [-0.01, +0.10] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.04 | [-1.40, +1.47] |
| ➖ | process_agent_standard_check | memory utilization | +0.03 | [-0.01, +0.06] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.01, +0.03] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.02 | [-0.05, +0.01] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.06 | [-0.10, -0.03] |
| ➖ | idle | memory utilization | -0.15 | [-0.19, -0.12] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.42 | [-0.45, -0.38] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 5 builds ahead! (estimated merge in less than 2h)
Use /merge -c to cancel this operation!
:rotating_light: MergeQueue
Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.
If you need support, contact us on Slack #ci-interfaces with those details!
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 47m)
Use /merge -c to cancel this operation!