datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[EBPF-384] migrate conntracker to use the new ebpfManager wrapper

Open val06 opened this issue 2 years ago • 1 comments

What does this PR do?

Migrates conntracker to use the new Manager wrapper with ErrorsTelemetryModifier instead of now deprecated ebpftelemetry.Manager

Motivation

better code structure

Additional Notes

another PR in a series to migrate all our ebpfPrograms to use the new telemetry pkg

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

val06 avatar Feb 27 '24 12:02 val06

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ac4840d6-2610-4f91-936e-b0af669b6cec Baseline: a085cc781ca351a1f1035d4afac481d61e1ae043 Comparison: aed643068efb6538f0dc73a49aa4f5cadaca32bd

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.73 [-4.84, +8.31]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.73 [-4.84, +8.31]
uds_dogstatsd_to_api_cpu % cpu utilization +0.61 [-0.86, +2.07]
idle memory utilization +0.51 [+0.46, +0.56]
process_agent_standard_check memory utilization +0.41 [+0.37, +0.45]
otel_to_otel_logs ingress throughput +0.25 [-0.39, +0.89]
process_agent_real_time_mode memory utilization +0.21 [+0.18, +0.25]
file_tree memory utilization +0.01 [-0.10, +0.12]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.03, +0.01]
trace_agent_msgpack ingress throughput -0.02 [-0.04, -0.01]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.09, -0.02]
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.21, -0.10]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 27 '24 13:02 pr-commenter[bot]

/merge

val06 avatar Feb 29 '24 17:02 val06

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 17:02 dd-devflow[bot]