datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[Backport 7.52.x] pkg/trace/api: limit simultaneous otlp requests, do not drop payloads

Open agent-platform-auto-pr[bot] opened this issue 1 year ago • 1 comments

Backport a396d12b70ad7337b30761efacde1d6101738959 from #23085.

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e8a2adfd-7eaf-429f-bece-e1827b8fe047 Baseline: 36d7ecd8fe36685c3bc3ee74ced1364f5bd1919b Comparison: 2ed261f6b64bb5358c8d25a880f7abf545e89d49 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.77 [-7.29, +5.75]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +1.21 [+1.15, +1.28]
process_agent_standard_check memory utilization +0.91 [+0.86, +0.96]
uds_dogstatsd_to_api_cpu % cpu utilization +0.85 [-0.57, +2.26]
process_agent_real_time_mode memory utilization +0.68 [+0.64, +0.73]
file_tree memory utilization +0.20 [+0.09, +0.31]
otel_to_otel_logs ingress throughput +0.16 [-0.47, +0.80]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.01]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.09, +0.00]
idle memory utilization -0.29 [-0.34, -0.24]
file_to_blackhole % cpu utilization -0.77 [-7.29, +5.75]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 26 '24 17:02 pr-commenter[bot]

/merge

kacper-murzyn avatar Feb 27 '24 08:02 kacper-murzyn

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 47m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 27 '24 08:02 dd-devflow[bot]