datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

processes: parse metadata for dotnet launcher

Open amarziali opened this issue 2 years ago • 1 comments

What does this PR do?

Add command metadata parser for dotnet core launcher. If the user launches a dll with the dotnet cli, we use the dll name as service name.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

amarziali avatar Feb 26 '24 16:02 amarziali

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 45ba308b-e86e-4f85-8eb4-dec60fb6e567 Baseline: ce0e515eda490bd5ec728d7aa15cb098c1ff9f72 Comparison: def2ef8cfab7edb3a17072b207ba236849778e16

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.75 [-7.29, +5.79]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +2.14 [+0.71, +3.57]
process_agent_standard_check_with_stats memory utilization +0.47 [+0.43, +0.50]
file_tree memory utilization +0.06 [-0.01, +0.13]
tcp_syslog_to_blackhole ingress throughput +0.04 [-0.01, +0.09]
process_agent_real_time_mode memory utilization +0.01 [-0.02, +0.05]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.05, +0.01]
idle memory utilization -0.06 [-0.09, -0.03]
otel_to_otel_logs ingress throughput -0.33 [-0.98, +0.32]
process_agent_standard_check memory utilization -0.41 [-0.45, -0.37]
file_to_blackhole % cpu utilization -0.75 [-7.29, +5.79]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 26 '24 18:02 pr-commenter[bot]

/merge

amarziali avatar Mar 01 '24 19:03 amarziali

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 19:03 dd-devflow[bot]