datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[windows] [cws] Enable windows CWS on release builds

Open derekwbrown opened this issue 1 year ago • 1 comments

What does this PR do?

Enables the Windows CWS feature on release builds.

Motivation

We are releasing windows CWS.

Additional Notes

Describe how to test/QA your changes

Install the agent. Enable CWS in system-probe.yaml and security-agent.yaml. restart the agent. Agent, system probe, and security agent should all be started. (verify with taskmanager or get-service -name data*)

derekwbrown avatar Feb 20 '24 19:02 derekwbrown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: bed8a3d4-c50d-430c-8930-96054e24a9ce Baseline: 8a928218504a6a8b89f05c17ba5093ba78056676 Comparison: d8020d0616d1d8173dd02e3dda75e910e385c4d6 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.99 [-5.58, +7.56]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.99 [-5.58, +7.56]
idle memory utilization +0.71 [+0.68, +0.75]
otel_to_otel_logs ingress throughput +0.35 [-0.26, +0.96]
process_agent_real_time_mode memory utilization +0.16 [+0.13, +0.18]
uds_dogstatsd_to_api_cpu % cpu utilization +0.06 [-1.36, +1.48]
trace_agent_msgpack ingress throughput +0.04 [+0.02, +0.05]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_standard_check_with_stats memory utilization -0.01 [-0.05, +0.03]
process_agent_standard_check memory utilization -0.03 [-0.07, +0.01]
trace_agent_json ingress throughput -0.04 [-0.08, -0.01]
file_tree memory utilization -0.07 [-0.16, +0.01]
tcp_syslog_to_blackhole ingress throughput -0.50 [-0.56, -0.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 20 '24 21:02 pr-commenter[bot]

/merge

kacper-murzyn avatar Feb 21 '24 08:02 kacper-murzyn

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 21 '24 08:02 dd-devflow[bot]