datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add first updater e2e test

Open raphaelgavache opened this issue 1 year ago • 1 comments

What does this PR do?

Add a first simple test that verifies files ownership with the updater. Tests are run manually with

 E2E_PIPELINE_ID=GITLAB_ID  aws-vault exec sso-agent-sandbox-account-admin -- invoke new-e2e-tests.run --targets ./tests/updater

or on every change in /cmd/updater, /pkg/updaters, /tests/updater link to new-e2e-updater test run

Motivation

First of many tests, all updater behaviours will be verified in tests/updater in the following weeks

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

raphaelgavache avatar Feb 20 '24 12:02 raphaelgavache

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: d7e8f354-d6ff-4579-868f-4adecd505240 Baseline: 3365b2a179dcbcee7655eae2e550444d712b1593 Comparison: 4fc81a491f975d8dee9cab161be9abc25a6d2653 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.35 [-6.22, +6.92]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.59 [+0.16, +3.03]
otel_to_otel_logs ingress throughput +0.77 [+0.11, +1.42]
process_agent_standard_check memory utilization +0.45 [+0.41, +0.49]
file_to_blackhole % cpu utilization +0.35 [-6.22, +6.92]
process_agent_real_time_mode memory utilization +0.18 [+0.15, +0.22]
tcp_syslog_to_blackhole ingress throughput +0.05 [-0.00, +0.11]
trace_agent_json ingress throughput +0.00 [-0.03, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
process_agent_standard_check_with_stats memory utilization -0.17 [-0.20, -0.13]
idle memory utilization -0.41 [-0.44, -0.37]
file_tree memory utilization -0.63 [-0.71, -0.55]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 20 '24 18:02 pr-commenter[bot]

/merge

raphaelgavache avatar Feb 26 '24 08:02 raphaelgavache

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 08:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 4 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 09:02 dd-devflow[bot]

:rotating_light: MergeQueue

There was an unexpected error while creating the working branch

This could indicate that something doesn't work properly with the build system or that this one has reached its maximum capacity. You can try to wait a bit and then re-add your pull request to the queue!

Details

child workflow execution error (type: mergequeue_private.MergeQueue_BuildWorkingBranch, workflowID: 7ec8045c-30d8-4803-9e57-a22f74f5c929_497, runID: 4c49607f-3474-43ab-9a49-c6926e72ca68, initiatedEventID: 497, startedEventID: 498): Child workflow timeout (type: StartToClose)

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 09:02 dd-devflow[bot]

/merge

raphaelgavache avatar Feb 26 '24 10:02 raphaelgavache

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 11 builds ahead! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 10:02 dd-devflow[bot]

/merge -p urgent

raphaelgavache avatar Feb 26 '24 12:02 raphaelgavache

:x: MergeQueue

PR already in the queue with status queued

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 12:02 dd-devflow[bot]

/merge -c

raphaelgavache avatar Feb 26 '24 12:02 raphaelgavache

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 26 '24 12:02 dd-devflow[bot]

/merge -p urgent

raphaelgavache avatar Feb 26 '24 12:02 raphaelgavache

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 8 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 12:02 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 12:02 dd-devflow[bot]

/merge -p urgent

raphaelgavache avatar Feb 26 '24 13:02 raphaelgavache

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 10 builds ahead! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 13:02 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 13:02 dd-devflow[bot]

/merge -p urgent

raphaelgavache avatar Feb 26 '24 18:02 raphaelgavache

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 18:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 9 builds ahead of this PR! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 18:02 dd-devflow[bot]